[vlc-devel] [PATCH V3 02/19] clock: add AddOriginPoint

[Thomas Guillem]

On Mon, Sep 9, 2019, at 18:05, Rémi Denis-Courmont wrote:
> Le maanantaina 9. syyskuuta 2019, 18.58.29 EEST Thomas Guillem a écrit :
> > On Sat, Sep 7, 2019, at 14:33, Rémi Denis-Courmont wrote:
> > > Le perjantaina 6. syyskuuta 2019, 18.20.32 EEST Thomas Guillem a écrit :
> > > > Will be used by the future "clock: forward clock update points" commit.
> > > 
> > > I don't see why there should be a table here. This is going to add
> > > impossible to handle error cases, potentially unbounded table size, and
> > > it's not at all according to the design from spring 2018.
> > 
> > Mainly to handle the TS case where the origin can change midstream if you
> > seek back to the first origin. But it's a corner case that is not
> > necessarily needed.
> 
> I don't think the clock has any business with play time. It's just a mapping 
> between system and media timestamps.
> 
> Mapping play time to media timestamps is the job of the demuxer (and yes, the 
> current DEMUX_GET_TIME/DEMUX_GET_POSITION concept is too limited).

Yes it should be in the demux. I put it in the clock in order to reduce the number of locks involved and to fix possible a lock-order-inversion.

After second thoughts, I can also forward an event to the player from the demux when the origin changes, keeping the same lock complexity.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel