[vlc-devel] [PATCH V3 02/19] clock: add AddOriginPoint

Rémi Denis-Courmont remi at remlab.net
Mon Sep 9 20:15:11 CEST 2019


Le maanantaina 9. syyskuuta 2019, 19.15.18 EEST Thomas Guillem a écrit :
> > Mapping play time to media timestamps is the job of the demuxer (and yes,
> > the current DEMUX_GET_TIME/DEMUX_GET_POSITION concept is too limited).
> Yes it should be in the demux. I put it in the clock in order to reduce the
> number of locks involved and to fix possible a lock-order-inversion.
> 
> After second thoughts, I can also forward an event to the player from the
> demux when the origin changes, keeping the same lock complexity.

AFAICT, we only need a demux control to query the current offset from PCR to 
NPT - presumably with program ID as parameter - as opposed to the current 
time.

Of course, it will glitch at the edge between two consecutive broadcasts, but 
it already does now, and I doubt it's completely avoidable.

-- 
Реми Дёни-Курмон
http://www.remlab.net/





More information about the vlc-devel mailing list