[vlc-devel] [RFC PATCH 1/4] demux: add DEMUX_GET_NPT

Thomas Guillem thomas at gllm.fr
Wed Sep 11 23:01:54 CEST 2019



On Wed, Sep 11, 2019, at 18:12, Rémi Denis-Courmont wrote:
> 	Hi,
> 
> NPT is just a more precise name for time. This patchset seems to use offsets, 
> which is probably better design, but the name is wrong.

Ok

> 
> Either way, I still think that the offset needs to be per-group - because 
> that's just of how EIT works. Different programs don't start and end their 
> consecutive broadcasts at the same time.
> 
> It's a pre-existing bug, but it's still a bug.

I think it's a bug for an other patchset. Every time related properties (time, len) are not per group. If we change it, we have to change time events to send update per group too, and there won't be a real usage for the input or the player. The player assume that all time events are for the current selected group. 

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list