[vlc-devel] [RFC PATCH 1/4] demux: add DEMUX_GET_NPT

[Thomas Guillem]

Hello,

Here is the final branch https://code.videolan.org/tguillem/vlc/commits/clock-update/17

I won't push Qt commits yet, they can be improved.
Finally, I used this demux control: DEMUX_GET_NORMAL_TIME

As I already said, it's not per-group since all time related events are not per group, this will complicate the ES_OUT_SET_TIMES control. It's a bug for an other patch set but I don't see the rush to fix it now.

On Wed, Sep 11, 2019, at 23:01, Thomas Guillem wrote:
> 
> 
> On Wed, Sep 11, 2019, at 18:12, Rémi Denis-Courmont wrote:
> > 	Hi,
> > 
> > NPT is just a more precise name for time. This patchset seems to use offsets, 
> > which is probably better design, but the name is wrong.
> 
> Ok
> 
> > 
> > Either way, I still think that the offset needs to be per-group - because 
> > that's just of how EIT works. Different programs don't start and end their 
> > consecutive broadcasts at the same time.
> > 
> > It's a pre-existing bug, but it's still a bug.
> 
> I think it's a bug for an other patchset. Every time related properties 
> (time, len) are not per group. If we change it, we have to change time 
> events to send update per group too, and there won't be a real usage 
> for the input or the player. The player assume that all time events are 
> for the current selected group. 
> 
> > 
> > -- 
> > Rémi Denis-Courmont
> > http://www.remlab.net/
> > 
> > 
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel