[vlc-devel] [vlc-commits] posix: rely on F_DUPFD_CLOEXEC

[Rémi Denis-Courmont]

Steve, all,

For the reference, I reckon that the TC agreed unanimously to have mandatory reviews for API changes, including both plugin and LibVLC API sets. Roughly if you need to change anything in include/ directory other than documentation.

There were inconclusive discussions whether to extend that to non-trivial core and bindings (src/, bin/, lib/) changes as well.

Le 24 septembre 2019 10:26:36 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2019-09-24 8:30, Rémi Denis-Courmont wrote:
>> And most of who anyway?! Denis, Felix and myself have all objected to
>mandatory reviews on more or less the same basis. David did not express
>an opinion that I'd be aware of.
>> 
>> Most people within VideoLabs maybe. But even there, it does not look
>to me that François wants mandatory reviews either, and Steve seems
>very ambivalent about it.
>
>I'll speak for myself. I thought it was agreed upon that code in the 
>core and libvlc should be reviewed before merging. Maybe I 
>misunderstood. I did not even know the Technical Committee had 
>discussions on that, left alone any decision taken.
>
>I think this would be a good thing, especially to avoid breaking other 
>platforms we don't test on. For bigger patchset it's also good to have 
>different opinion on an algorithm or some technical choice. For example
>
>the work on decoder device/video context is benefiting a lot from that.
>
>In the end there are hardly a case where a patch cannot wait a day or 
>two before being merged. Even (and especially) security issue patches 
>that must be rushed in a release should be reviewed first.
>
>I sometimes rush some on code I maintain and noone will rely
>review/test 
>the code and that would bloke more incoming patches. For example the 
>D3D/NVDEC decoder device. But that's outside of the core/libvlc.
>
>> So I'm counting 2 (you and Hugo) against 4 of the main VLC committers
>here. So much for "most".
>> 
>> Le 24 septembre 2019 01:32:36 GMT+03:00, Thomas Guillem
><thomas at gllm.fr> a écrit :
>>>
>>>
>>> On Mon, Sep 23, 2019, at 22:57, Rémi Denis-Courmont wrote:
>>>> Le maanantaina 23. syyskuuta 2019, 23.26.20 EEST Thomas Guillem a
>>> écrit :
>>>>> On Mon, Sep 23, 2019, at 18:20, Rémi Denis-Courmont wrote:
>>>>>> So me in public and everybody else privately. Same difference.
>>> That's
>>>>>> still
>>>>>
>>>>> I remember telling François and steve on this ML.
>>>>
>>>> All I see is asking François if he can send patches for review in
>the
>>> future.
>>>> Noting from Steve at all.
>>>
>>> I speak to Steve regularly, and we do video conf so I might have tel
>>> him this way. To be honest I don't remember.
>>>
>>>>
>>>> How convenient to remember something that did not happen (sources:
>>> vlc-devel
>>>> archives).
>>>>
>>>> Well, if that's it, then I remember that the committee did not
>>> approve any
>>>> review mandate. So I am going to flatly ignore all your comments on
>>> mandatory
>>>> reviews until the commitee or the GA passes a resolution on the
>topic
>>>
>>> Why so much tension ? Could we work together again ? It worked quite
>>> well in the past few months, every one were respecting each others
>and
>>> each others reviews. It can't work if you ignore me or if I ignore
>you
>>> since we are both main VLC developers...
>>>
>>> I know for a fact that most people want mandatory review. I think it
>>> will be voted during the next VDD. In the meantime, I would really
>love
>>> that all core commits go through the ML. I really apprecited your
>extra
>>> effort recently when you went throught the ML. And I always try to
>send
>>> good reviews.
>>>
>>>
>>>>
>>>> -- 
>>>> Реми Дёни-Курмон
>>>> http://www.remlab.net/
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté.
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190924/f688a8de/attachment.html>