[vlc-devel] [vlc-commits] posix: rely on F_DUPFD_CLOEXEC

Thomas Guillem thomas at gllm.fr
Tue Sep 24 21:39:59 CEST 2019

On Tue, Sep 24, 2019, at 20:37, Rémi Denis-Courmont wrote:
> Le tiistaina 24. syyskuuta 2019, 20.25.07 EEST Thomas Guillem a écrit :
> > > If you have a better take on why the ambience went so sour, with the same
> > > people, since winter, I'd like to hear it...
> > I do really think that you are the only one responsible for the bad
> > ambience.
> You literally started *this* flame-thread to criticize me for eliminating 
> *dead* code without review, and not even within the new defacto standard 24 
> hours review deadline (not for lack of reminding that one week was the rule of 
> thumb, from me).
> And you blame it on me? Conceited much?
> Remind me who was complaining about Denis' block work 

Complaining ? I just did a technical review. I said that I didn't like to duplicate 2000 lines of code, Denis didn't like it either, but there was no other good solution. We talked between each other and we concluded that we had to clean up some block fifo/list API usage before doing this frame/data split. That way, we won't have to duplicate everything? It is always a pleasure to work with Denis.

> or about Felix MacOS  work? 

Yes I complained that he broke the macOS UI, but then I was told to do the same thing with Qt. I'm not happy with that.

>Is there any active volunteer committer that you have not picked on in 
> the last semester?

That is called a review, no ? Yes I'm picky sometimes and nitpick a lot (sorry but I really hate -ed and long commit title).

> Meanwhile, did I pick on a volunteer in public?  Multiple times? 

For me, that's called asking nicely.

> Did I misrepresent a vote of the general assembly to support my own agenda?

I don't remember. Could you elaborate?

> Did I  break the any main user interface?

Yes, but I was told to do it and I didn't like it

> Did I complain about lack of review for verifiably trivial/non-functional changes?

Yes I guess

> Did I merge a patch that had been rejected?

Error happens and miscommunication happens, it will be a lot easier with gitlab.

> Did I flame a volunteer reviewer for non-technical reasons?

Asking to go through a review process is a technical reason

> Did I  flame a volunteer bug triager for closing bugs with technical motivation?

I complained about deleting bug, but closing it.

> What exactly did I do, other than not agree with you?

- You threatened to sue a student (Marvin). What is wrong with you ?
- You tried to sue the Videolan President (j-b), by the way, we didn't hear any news from it.
- You create vulnerability issues against your own team https://www.remlab.net/op/vlc-hls-ua-inject.shtml. Sorry but the "unknown reason" is obvious, you were never able to understand each other with Francois.
- You are very aggressive with new contributors. I can't count the number of time where I have to help external contributors privately because they don't understand your review. You are a very talented C developers with a lot of experience, and yet you can't understand that you should help interns or juniors developers instead of being harsh with them.
 - You never admit that you are wrong, so we all have to guess that if you didn't respond to a review answer for one week, it mean you were wrong and we can push. Being wrong on the internet is OK you know, I do that a lot personally.

> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list