[vlc-devel] Regarding the HTTP POST implementation

Alexandre Janniaux ajanni at videolabs.io
Thu Sep 26 13:42:55 CEST 2019


Hi,

Thank you for your interest in this !

First you need to check the previous patches that have been send for this.
You can check previous post in the mailing list. If you have a mail client
which can handle mbox format, you can download the whole mailing list at:

https://mailman.videolan.org/private/vlc-devel.mbox/vlc-devel.mbox

If you don't have one, I would suggest thunderbird or neomutt with a
notmuch indexer.

A POST implementation has already been suggested by Diogo Silva in
August 17 2017. Check [PATCH 00/10][RFC][WIP] libcloudstorage integration.
While it was breaking some layers, it gives you a good start for POST
integration. Just make sure you tackle authorship correctly.

I also have some WIP that I can share but couldn't find them back for
now.

About vlc_access, they can't be used for POST request as POST needs to
send data. You might want to implement this in a stream output instead.
There is a tracking ticket for this on the trac, that you might want to
ask ownership for if you really want to tackle this.

I don't have special opinion about using curl or not. You might have a
curl access/access output used if the library is available and a fallback
to internal implementation if not. It would need benchmarking to really
determine whether it is worth it or what we should have as default. But
in any case, maintaining code has cost and the main challenge is less in
the backend and more in the interface and exposure of functionality to
clients.

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, Sep 25, 2019 at 10:48:21PM +0530, Aniketh Girish wrote:
> Hi,
>
> Recently, I have been trying to add POST support to VLC(
> https://wiki.videolan.org/Bounties/#HTTP_POST_support). But I am still
> having a hard time understanding where should it go and how user use case
> should be. Thomas suggested that it, we need the POST API to get the data
> from the cloudstorage functionality(GSoC work) which is yet to be merged I
> believe. But still, I don't have a clear idea of how and where it should be
> implemented. But then Hugo suggested, Adding POST to access/http/ might be
> a more future proof way, we might eventually use that private API as the
> public HTTP API. Also suggested that why not include libcurl to do all sort
> of HTTP related functionalities, at least the POST here. Any suggestions or
> ideas on how to proceed with the HTTP POST and how to the use case of the
> POST implementation would be?
>
> Though I personally feel, it should be better to have our own networking
> protocol implementations as such rather than using an external lib, keeping
> in mind  that if at all we need to tweak an implementation for better
> performance or tweak the implementation for streaming alone(libcurl is a
> generic lib for any usecase web, streaming etc) and such, it should be
> better to have our own implementations- given we have someone to look after
> and maintain such code.
>
> Cheers.
> --
> Aniketh Girish
> Member at FOSS at Amrita <http://foss.amrita.ac.in/>
> Amrita University <http://amrita.edu>
> <https://github.com/Aniketh01>Github <https://github.com/Aniketh01> | GitLab
> <https://gitlab.com/Aniketh01/> | Blog <http://anikethfoss.wordpress.com> |
> Website <http://aniketh01.github.io>
>
> "For the Love of Code."

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list