[vlc-devel] [PATCH] Convert int to bool in Audio Bargraph Filter

[Rémi Denis-Courmont]

Le sunnuntaina 5. huhtikuuta 2020, 22.53.51 EEST Vedanta Nayak a écrit :
> Hello,
> This implements a fix for the audiobargraph audio filter GUI as
> mentioned in the comments.
> ---
>  modules/audio_filter/audiobargraph_a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/audio_filter/audiobargraph_a.c
> b/modules/audio_filter/audiobargraph_a.c index e744b52f24..d5bdad5be0
> 100644
> --- a/modules/audio_filter/audiobargraph_a.c
> +++ b/modules/audio_filter/audiobargraph_a.c
> @@ -74,9 +74,9 @@ vlc_module_begin ()
> 
>      add_obsolete_string( CFG_PREFIX "address" )
>      add_obsolete_integer( CFG_PREFIX "port" )
> -    add_integer( CFG_PREFIX "bargraph", 1, BARGRAPH_TEXT,
> BARGRAPH_LONGTEXT, false ) // FIXME: this is a bool +    add_bool(
> CFG_PREFIX "bargraph", false, BARGRAPH_TEXT, BARGRAPH_LONGTEXT, false )
> add_integer( CFG_PREFIX "bargraph_repetition", 4, BARGRAPH_REPETITION_TEXT,
> BARGRAPH_REPETITION_LONGTEXT, false ) -    add_integer( CFG_PREFIX
> "silence", 1, SILENCE_TEXT, SILENCE_LONGTEXT, false ) // FIXME: this is a
> bool +    add_bool( CFG_PREFIX "silence", false, SILENCE_TEXT,
> SILENCE_LONGTEXT, false ) add_integer( CFG_PREFIX "time_window", 5000,
> TIME_WINDOW_TEXT, TIME_WINDOW_LONGTEXT, false ) add_float( CFG_PREFIX
> "alarm_threshold", 0.02, ALARM_THRESHOLD_TEXT, ALARM_THRESHOLD_LONGTEXT,
> false ) add_integer( CFG_PREFIX "repetition_time", 2000,
> REPETITION_TIME_TEXT, REPETITION_TIME_LONGTEXT, false )

Why do you change the default values?

It might not matter here, but this patch changes the command line syntax in 
incompatible manner.

-- 
Rémi Denis-Courmont
Tapiolan uusi kaupunki, Uudenmaan tasavalta