[vlc-devel] [PATCH] Convert int to bool in Audio Bargraph Filter

[Vedanta Nayak]

Hello,

>the type in the variable won't match the type that is read.
The variable is already set to bool, however the module description
still used integer.

>Why do you change the default values?
That has been corrected.
---
 modules/audio_filter/audiobargraph_a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/audio_filter/audiobargraph_a.c b/modules/audio_filter/audiobargraph_a.c
index d5bdad5be0..4c7215153d 100644
--- a/modules/audio_filter/audiobargraph_a.c
+++ b/modules/audio_filter/audiobargraph_a.c
@@ -74,9 +74,9 @@ vlc_module_begin ()
 
     add_obsolete_string( CFG_PREFIX "address" )
     add_obsolete_integer( CFG_PREFIX "port" )
-    add_bool( CFG_PREFIX "bargraph", false, BARGRAPH_TEXT, BARGRAPH_LONGTEXT, false ) 
+    add_bool( CFG_PREFIX "bargraph", true, BARGRAPH_TEXT, BARGRAPH_LONGTEXT, false ) 
     add_integer( CFG_PREFIX "bargraph_repetition", 4, BARGRAPH_REPETITION_TEXT, BARGRAPH_REPETITION_LONGTEXT, false )
-    add_bool( CFG_PREFIX "silence", false, SILENCE_TEXT, SILENCE_LONGTEXT, false )
+    add_bool( CFG_PREFIX "silence", true, SILENCE_TEXT, SILENCE_LONGTEXT, false )
     add_integer( CFG_PREFIX "time_window", 5000, TIME_WINDOW_TEXT, TIME_WINDOW_LONGTEXT, false )
     add_float( CFG_PREFIX "alarm_threshold", 0.02, ALARM_THRESHOLD_TEXT, ALARM_THRESHOLD_LONGTEXT, false )
     add_integer( CFG_PREFIX "repetition_time", 2000, REPETITION_TIME_TEXT, REPETITION_TIME_LONGTEXT, false )
-- 
2.26.0