[vlc-devel] [PATCH v4 1/1] avformat: replace deprecated field in AVFormatContext

[Mehdi Sabwat]

Hi Rémi,



On Thu, Apr 9, 2020 at 4:18 PM Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le torstaina 9. huhtikuuta 2020, 0.02.28 EEST Mehdi Sabwat a écrit :
> > From: Mehdi Sabwat <mehdisabwat at gmail.com>
> >
> > Since Jan 21, 2018 (ea3672b7d67c432724bdbc8de0221f869b6a04c6)
> > filename field was deprecated in favor of `url` which now has
> > no length restrictions.
>
> I somehow doubt that they just gratuitiously renamed the field.
> URLs and filenames are very different things and this patch does not seem
> right


I think it was to remove the length restriction,
https://www.ffmpeg.org/doxygen/4.0/structAVFormatContext.html#a651c97cb2dcd2241d42f0062a0bbd4e3

>
>
>
Plus what I already pointed out.
>
>
The leak was removed, I thought you were talking about the second
av_strdup(), this one is freed by avformat_free_context() in
(avformat_CloseMux)



> --
> Rémi Denis-Courmont
> Hagalund ny stad, Nylands republik
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200409/322f6af3/attachment.html>