[vlc-devel] [PATCH v4 1/1] avformat: replace deprecated field in AVFormatContext

[Marvin Scholz]

On 9 Apr 2020, at 16:17, Rémi Denis-Courmont wrote:

> Le torstaina 9. huhtikuuta 2020, 0.02.28 EEST Mehdi Sabwat a écrit :
>> From: Mehdi Sabwat <mehdisabwat at gmail.com>
>>
>> Since Jan 21, 2018 (ea3672b7d67c432724bdbc8de0221f869b6a04c6)
>> filename field was deprecated in favor of `url` which now has
>> no length restrictions.
>
> I somehow doubt that they just gratuitiously renamed the field.
> URLs and filenames are very different things and this patch does not 
> seem right.

They did not rename, they added a new field to phase out the filename 
field.

Internally they do s->url = av_strdup(filename) so we can use the new
url field for what we used the filename field before.

>
> Plus what I already pointed out.

What do you mean? I you mean the leak, no it does not leak
as it is freed in avformat_free_context().

>
> -- 
> Rémi Denis-Courmont
> Hagalund ny stad, Nylands republik
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel