[vlc-devel] [PATCH v4 1/1] avformat: replace deprecated field in AVFormatContext

[Alexandre Janniaux]

Hi,

On Thu, Apr 09, 2020 at 05:17:54PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 9. huhtikuuta 2020, 0.02.28 EEST Mehdi Sabwat a écrit :
> > From: Mehdi Sabwat <mehdisabwat at gmail.com>
> >
> > Since Jan 21, 2018 (ea3672b7d67c432724bdbc8de0221f869b6a04c6)
> > filename field was deprecated in favor of `url` which now has
> > no length restrictions.
>
> I somehow doubt that they just gratuitiously renamed the field.
> URLs and filenames are very different things and this patch does not seem right.
>
> Plus what I already pointed out.

I sent LGTM after testing with sanitizer while checking that
the code is correctly called, with a recent-enough ffmpeg,
and looking at the corresponding release note from ffmpeg.

Regards,
--
Alexandre Janniaux
Videolabs