[vlc-devel] [PATCH v3 02/14] src: add cleaner md5 API

[Marvin Scholz]

On 8 Apr 2020, at 19:07, Rémi Denis-Courmont wrote:

> Le keskiviikkona 8. huhtikuuta 2020, 19.47.54 EEST Marvin Scholz a écrit :
>> On 8 Apr 2020, at 17:48, Rémi Denis-Courmont wrote:
>>> Le keskiviikkona 8. huhtikuuta 2020, 18.20.30 EEST Francois Cartegnie
>>> a écrit
>>>
>>>> Le 08/04/2020 à 17:08, Rémi Denis-Courmont a écrit :
>>>>> And the FinishHex could be a static inline so as not to couple
>>>>> unrelated
>>>>> conversion and hashing routines.
>>>>
>>>> That will force a new include
>>>
>>> Sigh, fine then use a do-while(0) macro.
>>
>> Whats the benefit of a static inline function or a macro vs the way
>> I do it now?
>
> What François complained about - no need for extra #include

I still don't really understand how I am supposed to do that…
Should I just make a macro that calls vlc_hash_md5_Finish doing
an intermediate copy and then call vlc_hex_encode_binary on that?
(As I can't call md5_final in the header obviously)

And I still don't understand whats the benefit of doing that,
maybe I am misunderstanding something…

>
> -- 
> Rémi Denis-Courmont
> Ville neuve de Tapiola, République d´Uusimaa
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel