[vlc-devel] [PATCH v3 02/14] src: add cleaner md5 API

Francois Cartegnie fcvlcdev at free.fr
Mon Apr 13 13:51:05 CEST 2020

Le 12/04/2020 à 22:25, Marvin Scholz a écrit :

>> What François complained about - no need for extra #include
> I still don't really understand how I am supposed to do that…
> Should I just make a macro that calls vlc_hash_md5_Finish doing
> an intermediate copy and then call vlc_hex_encode_binary on that?
> (As I can't call md5_final in the header obviously)
> And I still don't understand whats the benefit of doing that,
> maybe I am misunderstanding something…

I don't know why people are so focused in adding an hex md5 function to
refactor 3 lines used in 5 places. Just drop it.

Francois Cartegnie
VideoLAN - VLC Developer

More information about the vlc-devel mailing list