[vlc-devel] [PATCH 2/4] fifo: inline trivial functions

[Thomas Guillem]

On Mon, Apr 13, 2020, at 13:05, Alexandre Janniaux wrote:
> Hi,
> 
> On Mon, Apr 13, 2020 at 01:46:39PM +0300, Rémi Denis-Courmont wrote:
> > Le maanantaina 13. huhtikuuta 2020, 13.34.07 EEST Alexandre Janniaux a écrit :
> > > Hi,
> > >
> > > It seems weird to do such work on deprecated function.
> >
> > It makes it easier to transition the *back* end in the following patches.
> 
> Mentioning this in the commit message is probably a good idea
> as it will be easier to follow why you made such change.

Why you ignored this review ? The commit has been pushed without any explanation in the commit message.
The reason of a commit should be on the commit message as a priority.

> 
> >
> > > What is planned for those functions in the long run?
> >
> > That's a *front* end question, that's orthogonal to this patchset. And I can't
> > speak for other people. But given that it's primarily the muxers, I guess
> > nobody cares and there are no plans.
> >
> 
> That aws not intended as blocking for your review yes, but
> as I was mentioning this aspect in your patchset it seems
> logical to raise the question.
> 
> If it confuses you I can probably open a new mail thread.
> 
> > > Can we create a ticket for it?
> >
> > I don't think a ticket helps in any way. There are already warnings. If
> > somebody decides to fix some of them, it's unlikely that they'll know to search
> > for, and find, a ticket.
> >
> > --
> > Rémi Denis-Courmont
> > Tapiolan uusi kaupunki, Uudenmaan tasavalta
> >
> >
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel