[vlc-devel] [PATCH 2/4] fifo: inline trivial functions

Rémi Denis-Courmont remi at remlab.net
Mon Apr 13 13:37:37 CEST 2020


Le maanantaina 13. huhtikuuta 2020, 14.25.43 EEST Thomas Guillem a écrit :
> On Mon, Apr 13, 2020, at 13:05, Alexandre Janniaux wrote:
> > Hi,
> > 
> > On Mon, Apr 13, 2020 at 01:46:39PM +0300, Rémi Denis-Courmont wrote:
> > > Le maanantaina 13. huhtikuuta 2020, 13.34.07 EEST Alexandre Janniaux a 
écrit :
> > > > Hi,
> > > > 
> > > > It seems weird to do such work on deprecated function.
> > > 
> > > It makes it easier to transition the *back* end in the following
> > > patches.
> > 
> > Mentioning this in the commit message is probably a good idea
> > as it will be easier to follow why you made such change.
> 
> Why you ignored this review ?


Because I don't have a time machine and I'm not going to force push just to 
add a comment statement that it's for the next change.

-- 
Rémi Denis-Courmont
Tapiola new town, Uusimaan Republic





More information about the vlc-devel mailing list