[vlc-devel] [PATCH 05/25] cpu: force feature support runtime check

Alexandre Janniaux ajanni at videolabs.io
Tue Apr 14 16:57:52 CEST 2020


On Tue, Apr 14, 2020 at 05:45:18PM +0300, Rémi Denis-Courmont wrote:
> Le tiistaina 14. huhtikuuta 2020, 17.35.42 EEST Alexandre Janniaux a écrit :
> > Hi,
> >
> > Isn't vlc_CPU checked only in initialization steps to choose
> > the correct variant?
> No.

Can't we just remove the few case where it's not calling it
during initialization? At the same time, it would remove
uneeded atomic operation on hot paths.

It's mainly done your way in copy.c.

> > What is the performance hit?
> If you had read the patch, it would be obvious.

I find this aggressive and irrelevant.

Alexandre Janniaux

More information about the vlc-devel mailing list