[vlc-devel] [PATCH 05/25] cpu: force feature support runtime check

[Thomas Guillem]

On Tue, Apr 14, 2020, at 16:57, Alexandre Janniaux wrote:
> Hi,
> 
> On Tue, Apr 14, 2020 at 05:45:18PM +0300, Rémi Denis-Courmont wrote:
> > Le tiistaina 14. huhtikuuta 2020, 17.35.42 EEST Alexandre Janniaux a écrit :
> > > Hi,
> > >
> > > Isn't vlc_CPU checked only in initialization steps to choose
> > > the correct variant?
> >
> > No.
> 
> Can't we just remove the few case where it's not calling it
> during initialization? At the same time, it would remove
> uneeded atomic operation on hot paths.

Indeed, we could fix the few case where vlc_CPU is checked often.

In that case, I'm OK with this patch, that is simplifying it a lot.

> 
> It's mainly done your way in copy.c.
> 
> >
> > > What is the performance hit?
> >
> > If you had read the patch, it would be obvious.
> 
> I find this aggressive and irrelevant.
> 
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel