[vlc-devel] [PATCH 04/25] cpu: add CPU feature masking

Victorien Le Couviour victorien.lecouviour.tuffet at gmail.com
Tue Apr 14 18:32:54 CEST 2020


I looked at the file a bit more, I see the tests are actually in the file
at the end.
And it does test the SSE2.
But so that's "fine" I guess when you have just one thing to test.
What I mean is, take the deinterlace filters, I would need to do that in
every file, that's quite dirty in my opinion.
Having one piece of code that just test all of them, in its own file, in
the test directory,
does seem like the right the way to go, at least if we want to keep the
codebase somewhat clean.
And it's what I want.
I don't want to copy paste my tests and bench code all over the place right
in the modules files....

On Tue, Apr 14, 2020 at 6:23 PM Victorien Le Couviour <
victorien.lecouviour.tuffet at gmail.com> wrote:

> On Tue, Apr 14, 2020 at 5:54 PM Rémi Denis-Courmont <remi at remlab.net>
> wrote:
>> Le tiistaina 14. huhtikuuta 2020, 18.42.56 EEST Victorien Le Couviour a
>> écrit
>> :
>> > Hi,
>> >
>> > Doesn't that imply I'd have to write a version per feature I want to
>> test?
>> No but it does imply that you don't kludge the LibVLC run-time to suit
>> your
>> specific test. Like everybody else who's ever written a test case here.
> I don't see how this can work.
> I'm testing / benching, individual implementions of the same function,
> this has to be done incrementally, therefore something like, having no
> opti, then just SSE2, the SSSE3, then AVX2.
> How can you do that through preproc tricks?
> I get your example Thomas, but that's just to test stuff with no opti,
> it's one case only, here we want all of them to run in the same
> program, one after the other.
> In the tests / benchs, I'm disabling everything, and incrementally
> re-enabling features.
> This kind of things can only be done at run-time.
>> --
>> Rémi Denis-Courmont
>> Tapiolan uusi kaupunki, Uudenmaan tasavalta
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200414/9ee4c158/attachment.html>

More information about the vlc-devel mailing list