[vlc-devel] [PATCH 04/25] cpu: add CPU feature masking

[Rémi Denis-Courmont]

Le tiistaina 14. huhtikuuta 2020, 19.23.18 EEST Victorien Le Couviour a écrit 
:
> On Tue, Apr 14, 2020 at 5:54 PM Rémi Denis-Courmont <remi at remlab.net> wrote:
> > Le tiistaina 14. huhtikuuta 2020, 18.42.56 EEST Victorien Le Couviour a
> > écrit
> > 
> > > Hi,
> > > 
> > > Doesn't that imply I'd have to write a version per feature I want to
> > 
> > test?
> > 
> > No but it does imply that you don't kludge the LibVLC run-time to suit
> > your specific test. Like everybody else who's ever written a test case
> > here.
> 
> I don't see how this can work.

So you can patch the Makefile to include select C file in your benchmark tool, 
but you cannot (think to) patch it to have different CFLAGS and a different 
vlc_CPU() implementation?

That's what I call taking reviewers for fools, and it really pisses me off.

-- 
Rémi Denis-Courmont
Tapiola new town, Uusimaan Republic