[vlc-devel] [PATCH 1/1] Return DBus error message instead of infinite loop

[Rémi Denis-Courmont]

Okay but that just ends up breaking the normal return code path, so it seems wrong even then.

Le 20 avril 2020 09:56:13 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>hello,
>
>On Sun, Apr 19, 2020, at 10:55, Rémi Denis-Courmont wrote:
>> Le sunnuntaina 19. huhtikuuta 2020, 11.05.02 EEST Jorge Bellon-Castro
>a écrit 
>> :
>> > Hello again,
>> > There is an earlier check doing the same goto.
>> 
>> That can't be right.
>> Existing code cannot goto to a label that does not exist yet.
>
>This was also what I thought when I first read the diff, then if you
>look again, you will see:
>
>-invalid_track_id:
>+invalid_track_id:
>
>> 
>> Also the patch seems to emit an error every time, even when there's
>no error.
>> 
>> -- 
>> Rémi Denis-Courmont
>> Hagalund ny stad, Nylands republik
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200420/56528fef/attachment.html>