[vlc-devel] [PATCH 1/1] Return DBus error message instead of infinite loop

Jorge Bellon-Castro jbelloncastro at gmail.com
Mon Apr 20 17:33:42 CEST 2020

> That can't be right.
> Existing code cannot goto to a label that does not exist yet.

The label existed previously, but was located in the line that this
patch inserts the additional goto, instead of at the end of the
function. See: modules/control/dbus/dbus_tracklist.c:143

> Also the patch seems to emit an error every time, even when there's no error.

The error should not be returned in normal conditions because the
REPLY_SEND macro includes a return statement, which can be seen in
I have tested this by sending a GetMetadata method invocation message
via DBus with a valid object "/org/videolan/vlc/playlist/0" and an
invalid one "/org/videolan/vlc/playlist/10".

More information about the vlc-devel mailing list