[vlc-devel] [PATCH] lib: add libvlc_video_set_spu_text_scale API

[Thomas Guillem]

On Mon, Apr 20, 2020, at 19:27, Mark Lee wrote:
> Hi,
> 
> The --sub-text-scale command-line switch was already an integer in VLC 3.x, and internally uses var_CreateInteger, var_GetInteger and so on.
> 
> From the review comments so far:
> - you would prefer float rather than int for the proposed new LibVLC API method
> - you do not want to have mismatched float for the LibVLC API and int for the corresponding VLC command line option
> 
> So does that mean for this patch to be acceptable you would want it to include a change to the preexisting --sub-text-scale switch to make that switch a float instead of an int?

Hello, your last patch is OK for me. I will merge it tomorrow if there is no other comments from VLC developers.

Bonus: should we change the --sub-text-scale type ? But this doesn't prevent your patch to be merged.

> 
> Regards,
> 
> On Mon, 20 Apr 2020 at 14:56, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> Le maanantaina 20. huhtikuuta 2020, 15.34.44 EEST Thomas Guillem a écrit :
>>  > Hello, thanks for this patch and for responding to our review very quickly.
>>  > 
>>  > I don't have any preferences regarding Integer of float for scale. But do we
>>  > really want to have float for libvlc and int for vlc command line options ?
>> 
>>  Of course not. We use float everywhere except UI, e.g. --rate or --zoom.
>> 
>> 
>>  -- 
>>  雷米‧德尼-库尔蒙
>> http://www.remlab.net/
>>  Rémi Denis-Courmont
>> 
>> 
>> 
>>  _______________________________________________
>>  vlc-devel mailing list
>>  To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200420/c633351c/attachment.html>