[vlc-devel] [PATCH] contribs: srt: avoid auto-selection on darwin OS

[Rémi Denis-Courmont]

Le maanantaina 20. huhtikuuta 2020, 17.48.28 EEST Alexandre Janniaux a écrit :
> Hi,
> 
> > Why disable on desktop macOS though?
> 
> That's a good question but I thought I made it clear in
> my patch content.

The patch content makes it clear why GnuTLS cannot be had on iOS. I failed to 
find an explanation for disabling GnuTLS on desktop.

> GnuTLS contribs rules have:
> 
>     ifdef BUILD_NETWORK
>     ifndef HAVE_DARWIN_OS
>     PKGS += gnutls
>     endif
>     endif

Yes, because the macOS devs prefer to use their own thing for TLS in VLC.

> Thus enabling srt contrib even on macosx is like removing
> this ifndef condition.

> Adding the condition on srt makes sure the behaviour is respected
> everywhere.

I don't think disabling streaming features on desktop macOS is respected 
behaviour of the BUILD_NETWORK parameter.

> I would have wanted to
> write something like «if gnutls is to be used, then enable
> srt» but I don't know whether it's writable or not, and if it
> makes sense since you can enable srt yourself if you enable
> gnutls yourself.

I don't think that's possible with Makefiles nor desirable.
We'd get multiple "solutions", with no explicit control which one gets picked.

As long as contribs are only used by VLC, the system is fine. If we had to 
support other reverse dependencies, then we'd have to reorganize how PKGS is 
computed. But that's a different topic.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/
Rémi Denis-Courmont