[vlc-devel] [PATCH] contribs: srt: avoid auto-selection on darwin OS

[Alexandre Janniaux]

Hi,

Forget what I said, it makes no sense to compile GnuTLS if
there is no dependency nor VLC client using it on MacOSX.

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, Apr 21, 2020 at 03:21:12PM +0200, Alexandre Janniaux wrote:
> Hi,
>
> Thank you for the precise answer!  I'll adapt the patch to
> iOS only then.
>
> I also saw the case of vncclient as I have a local branch
> for adding iOS armv7 CI.
>
> Would it make sense to replace the check of HAVE_DARWIN_OS
> into HAVE_IOS / HAVE_TVOS in gnutls contrib then?
>
> Regards,
> --
> Alexandre Janniaux
> Videolabs
>
> On Mon, Apr 20, 2020 at 08:27:58PM +0200, David Fuhrmann wrote:
> > Hi Alexande,
> >
> > Yes, gnutls is currently built for macOS, because some contrib dependencies need it (not only srt, but also vncclient as it looks like).
> >
> > This is known (at least for me) and accepted, because gnutls fully works for macOS as it is.
> > Therefore I would prefer to keep it enabled for those contribs.
> >
> > The main gnutls contrib was disabled as in the past we had securetrcansport as the main TLS module for VLC. Currently, we effectively compile both, but this does not really hurt.
> >
> > BR. David
> >
> > > Am 20.04.2020 um 16:48 schrieb Alexandre Janniaux <ajanni at videolabs.io>:
> > >
> > > Hi,
> > >
> > >> Why disable on desktop macOS though?
> > >
> > > That's a good question but I thought I made it clear in
> > > my patch content.
> > >
> > > GnuTLS contribs rules have:
> > >
> > >    ifdef BUILD_NETWORK
> > >    ifndef HAVE_DARWIN_OS
> > >    PKGS += gnutls
> > >    endif
> > >    endif
> > >
> > > Thus enabling srt contrib even on macosx is like removing
> > > this ifndef condition. Adding the condition on srt makes sure
> > > the behaviour is respected everywhere. I would have wanted to
> > > write something like «if gnutls is to be used, then enable
> > > srt» but I don't know whether it's writable or not, and if it
> > > makes sense since you can enable srt yourself if you enable
> > > gnutls yourself.
> > >
> > > As I'm not a maintainer of macosx and ios stuff I don't know
> > > whether GnuTLS should be enabled or not on MacOSX, but it is
> > > far more likely that the srt contrib has been added without
> > > care for this ifndef condition than GnuTLS been wrongly
> > > disabled on macosx, especially since macosx has it's own
> > > module for TLS stuff in VLC.
> > >
> > > I mainly expect review from iOS/MacOSX people before merging
> > > this patch though.
> > >
> > > Regards,
> > > --
> > > Alexandre Janniaux
> > > Videolabs
> > >
> > > On Mon, Apr 20, 2020 at 05:17:27PM +0300, Rémi Denis-Courmont wrote:
> > >> Le maanantaina 20. huhtikuuta 2020, 17.02.35 EEST Alexandre Janniaux a écrit :
> > >>> ---
> > >>> contrib/src/srt/rules.mak | 4 ++++
> > >>> 1 file changed, 4 insertions(+)
> > >>>
> > >>> diff --git a/contrib/src/srt/rules.mak b/contrib/src/srt/rules.mak
> > >>> index c9dbb59db8..a5b5bafee1 100644
> > >>> --- a/contrib/src/srt/rules.mak
> > >>> +++ b/contrib/src/srt/rules.mak
> > >>> @@ -4,8 +4,12 @@ SRT_VERSION := 1.3.1
> > >>> SRT_URL := $(GITHUB)/Haivision/srt/archive/v$(SRT_VERSION).tar.gz
> > >>>
> > >>> ifdef BUILD_NETWORK
> > >>> +# GnuTLS is not built on iOS (nettle has incompatible license) and MacOSX
> > >>> +# so avoid requiring it.
> > >>> +ifndef HAVE_DARWIN_OS
> > >>> PKGS += srt
> > >>> endif
> > >>> +endif
> > >>
> > >> Why disable on desktop macOS though?
> > >>
> > >>>
> > >>> ifeq ($(call need_pkg,"srt >= 1.3.1"),)
> > >>> PKGS_FOUND += srt
> > >>
> > >>
> > >> --
> > >> Реми Дёни-Курмон
> > >> http://www.remlab.net/
> > >> Rémi Denis-Courmont
> > >>
> > >>
> > >>
> > >> _______________________________________________
> > >> vlc-devel mailing list
> > >> To unsubscribe or modify your subscription options:
> > >> https://mailman.videolan.org/listinfo/vlc-devel
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel