[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Alexandre Janniaux]

Hi,

Thanks for review,

Indeed the commit is not clear enough and doesn't indicate
where this file comes from.

The content of this file is extracted from the macosx build
scripts, `extras/package/macosx/env/`, from the function
`vlcSetSymbolEnvironment` which was called by the apple script
before.

I'll rephrase the long commit message as follow locally:

```
MacOSX builds and iOS builds need fixups for the autoconf function
lookup as functions might be available with newer SDK but not available
with the target SDK currently supported, and autoconf doesn't detect
that correctly. These fixups are made through environment variables
declared in extras/package/macosx/env.build.sh. They are also needed
both for contribs and VLC itself.

As long as reconfiguration doesn't happen, it is possible to compile
VLC using make without sourcing the script. However the contribs are
not storing those exports and might fail during the middle of build
if the sourcing has been forgotten.

This patch allows building the contrib with make directly, without
needing to call the build script again or redefine the correct
environment variables before.
```

I didn't go further for having better autoconf integration as we
plan to move VLC to meson. I consider that the build script is
enough since it forces a new configuration.

Regards.
--
Alexandre Janniaux
Videolabs


On Thu, Apr 30, 2020 at 12:15:51AM +0300, Martin Storsjö wrote:
> On Wed, 29 Apr 2020, Alexandre Janniaux wrote:
>
> > It allows building the contrib with make directly, without needing to
> > call the build script again or redefine the correct environment
> > variables before.
> > ---
> > contrib/bootstrap                |  9 ++++++++
> > extras/package/apple/build.sh    |  1 +
> > extras/package/apple/symbols.mak | 37 ++++++++++++++++++++++++++++++++
> > 3 files changed, 47 insertions(+)
> > create mode 100644 extras/package/apple/symbols.mak
>
> I don't really see how the commit message and the commit contents match up
> here - or I don't really understand what's going on.
>
> What's symbols.mak, why hasn't that been needed before? The commit message
> talks about setting things (variables?) via makefiles instead of environment
> variables - I would expect it to be things like CC for the cross target and
> such, but then the commit tries to override autotools detections?
>
> // Martin
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel