[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Martin Storsjö]

On Thu, 30 Apr 2020, Alexandre Janniaux wrote:

> I'll rephrase the long commit message as follow locally:
>
> ```
> MacOSX builds and iOS builds need fixups for the autoconf function
> lookup as functions might be available with newer SDK but not available
> with the target SDK currently supported, and autoconf doesn't detect
> that correctly. These fixups are made through environment variables
> declared in extras/package/macosx/env.build.sh. They are also needed
> both for contribs and VLC itself.
>
> As long as reconfiguration doesn't happen, it is possible to compile
> VLC using make without sourcing the script. However the contribs are
> not storing those exports and might fail during the middle of build
> if the sourcing has been forgotten.
>
> This patch allows building the contrib with make directly, without
> needing to call the build script again or redefine the correct
> environment variables before.
> ```

Thanks, that clarifies things a bit more.

>From looking at the patch - it adds a new copy of these autotools 
overrides - but with them in place here, could the old ones be removed? 
(That makes the patch much easier to read for a casual observer like me - 
"move hack from place X to Y" - instead of something that looks like a 
completely new hack.) :-)

> I didn't go further for having better autoconf integration as we
> plan to move VLC to meson. I consider that the build script is
> enough since it forces a new configuration.

While VLC itself would be moved to meson, I wouldn't think the configure 
build would be migrated to that yet - and this patch is about contribs 
right?

// Martin