[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Rémi Denis-Courmont]

Instead of building with the SDK for the target lowest version, they build with the newest, so autoconf correctly detects stuff that's in the SDK but not the target.

Of course, this is wrong and it won't work with anything other than autoconf doing the same (cmake, meson...) or if the test name is changed.

Le 30 avril 2020 00:15:51 GMT+03:00, "Martin Storsjö" <martin at martin.st> a écrit :
>On Wed, 29 Apr 2020, Alexandre Janniaux wrote:
>
>> It allows building the contrib with make directly, without needing to
>> call the build script again or redefine the correct environment
>> variables before.
>> ---
>> contrib/bootstrap                |  9 ++++++++
>> extras/package/apple/build.sh    |  1 +
>> extras/package/apple/symbols.mak | 37
>++++++++++++++++++++++++++++++++
>> 3 files changed, 47 insertions(+)
>> create mode 100644 extras/package/apple/symbols.mak
>
>I don't really see how the commit message and the commit contents match
>up 
>here - or I don't really understand what's going on.
>
>What's symbols.mak, why hasn't that been needed before? The commit
>message 
>talks about setting things (variables?) via makefiles instead of 
>environment variables - I would expect it to be things like CC for the 
>cross target and such, but then the commit tries to override autotools 
>detections?
>
>// Martin
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200430/c6f23d8f/attachment.html>