[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Martin Storsjö]

On Thu, 30 Apr 2020, Alexandre Janniaux wrote:

> Hi,
>
> On Thu, Apr 30, 2020 at 12:38:02PM +0300, Martin Storsjö wrote:
>>
>> From looking at the patch - it adds a new copy of these autotools overrides
>> - but with them in place here, could the old ones be removed? (That makes
>> the patch much easier to read for a casual observer like me - "move hack
>> from place X to Y" - instead of something that looks like a completely new
>> hack.) :-)
>
> I can add the code move for macosx, but I didn't want to
> change both MacOSX and apple build scripts at the same time,
> especially since I cannot compile for MacOSX yet on my linux
> because of build script issues.

Ah, I see. A note about that makes it clearer.

> I expected the change in extras/package/apple/build.sh to be
> enough to understand but just realised right now that it was
> missing the line deletion:
>
> ```
> vlcSetSymbolEnvironment > /dev/null
> +. "${VLC_SCRIPT_DIR}/symbols.mak"
> ```
>
> should have been
>
> ```
> -vlcSetSymbolEnvironment > /dev/null
> +. "${VLC_SCRIPT_DIR}/symbols.mak"
> ```
>
> The sourcing of env.build.sh could then be removed after
> usage of vlcGetRootDir is removed but I didn't investigate
> why it was needed to follow symlinks and such and who is
> using this feature.
>
> That being fixed, I'll also try moving the macosx part and
> test it to clarify this patch.

Ok, great - no need to do all at once as long as the status is clear :-)

>>
>> > I didn't go further for having better autoconf integration as we
>> > plan to move VLC to meson. I consider that the build script is
>> > enough since it forces a new configuration.
>>
>> While VLC itself would be moved to meson, I wouldn't think the configure
>> build would be migrated to that yet - and this patch is about contribs
>> right?

Sorry, I typoed here. I meant "I wouldn't think the _contribs_ build would 
be migrated to meson".

// Martin