[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable
remi at remlab.net
Thu Apr 30 23:06:15 CEST 2020
Le torstaina 30. huhtikuuta 2020, 22.57.30 EEST Marvin Scholz a écrit :
> On 30 Apr 2020, at 21:03, Rémi Denis-Courmont wrote:
> > Le torstaina 30. huhtikuuta 2020, 18.10.04 EEST Alexandre Janniaux a
> > écrit :
> >> Hi,
> >> I'm not sure to understand why since you cannot make it work
> >> reliably in the build script alone.
> > I don't even know what you are talking about here.
> You said it does not belong in the generic contrib files,
> so where else should we put it?
English is read top to bottom, not bottom to top.
> The reason to have it included in contribs Makefile is so we do not
> always have to invoke wrapper scripts that add layers of abstraction and
> possible bugs.
You're not fixing any bugs here. You're adding bugs to the common contribs code
and violating at least two layers of abstractions with assumptions that aren't
More information about the vlc-devel