[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Marvin Scholz]

On 30 Apr 2020, at 21:03, Rémi Denis-Courmont wrote:

> Le torstaina 30. huhtikuuta 2020, 18.10.04 EEST Alexandre Janniaux a 
> écrit :
>> Hi,
>>
>> I'm not sure to understand why since you cannot make it work
>> reliably in the build script alone.
>
> I don't even know what you are talking about here.

You said it does not belong in the generic contrib files,
so where else should we put it?

>
>> You also refused a patch invoking the fact macosx/ios
>> developers shouldn't call build/configure script each time
>> they need to build, highlighting that is was self-inflicted
>> pain.
>
> Uh? Most if not all contrib rules will forcefully rerun their 
> configure anyway
> when rebuilding. Not that you need to do that very often.
>
> (And for VLC proper, you can't avoid rerunning it anyway. If you know 
> what you
> are doing, enable the autoconf cache to speed configure up.)

The reason to have it included in contribs Makefile is so we do not 
always have
to invoke wrapper scripts that add layers of abstraction and possible
bugs.

>
>>> There's moving hacks around then there's moving hacks around.
>>
>> Please not that the intent it not just moving a hack, but
>> mainly ensuring the build of contribs doesn't depends upon
>> your ac_cv_* build environment variable. Fixing this hack
>> is out of the scope of my darwin and autofoo skills.
>
> I don't have any ac_cv_* variables in contribs that I'd know of.
>

The issue is that those checks need to be overwritten with these
env variables, else configure will get incorrect results, because the
autoconf check for function existence is fundamentally flawed with
how it was designed to work. So it can not work for any cases where
the function declaration provides crucial information for the linker,
as autoconf will do the check without the right headers included.
Unless we fix autoconf, patch all dependencies, this is unfixable and
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel