[vlc-devel] [PATCH 19/19] picture: remove unused resource parameter from picture_NewFromResource

Thomas Guillem thomas at gllm.fr
Wed Aug 12 11:07:33 CEST 2020


Hello,

On Fri, Jul 31, 2020, at 06:34, Steve Lhomme wrote:
> On 2020-07-30 17:58, RĂ©mi Denis-Courmont wrote:
> > Hi,
> > 
> > Frankly, the function deserves a new name if it can only wrap preallocated
> > opaque buffers anymore. Alternatively, introduce a new function and then remove
> > the old one, depending how you prefer to split the patchset.
> 
> I originally did that, but it makes the patch more complicated to read. 
> (in fact I had the other function and then realized is was just 
> picture_NewFromResource without the resources param).
> 
> How about picture_NewWithDestroy() ?

or picture_NewWithGC().

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list