[vlc-devel] [PATCH v2 02/16] qt: don't load DComp backend when the device doesn't support D3D11 features

[Pierre Lamot]

On 2020-08-17 08:33, Steve Lhomme wrote:
> On 2020-08-17 8:27, Steve Lhomme wrote:
>> This is going to be quite limiting for people still using D3D11, 
>> likely with old GPUs.
> 
> s/D3D11/win7/
> They likely have a GPU that only support 9.3 features in D3D11.
> 
>> Why is this limit needed ? In the vout we can't render NV12 directly, 
>> but it can be worked around with a conversion filter.

The limitation is not for the video part but rather for the bridge 
between Qt/Angle and DirectComposition. Maybe that's possible, but quite 
the amount of work and as you said after, the win7 composition do 
provides composition for systems with lower configurations.

>> On 2020-08-14 18:43, Pierre Lamot wrote:
>>> ---
>>>   modules/gui/qt/maininterface/compositor_dcomp.cpp | 9 +++++++--
>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/modules/gui/qt/maininterface/compositor_dcomp.cpp 
>>> b/modules/gui/qt/maininterface/compositor_dcomp.cpp
>>> index 69b4145498..23b0612a9e 100644
>>> --- a/modules/gui/qt/maininterface/compositor_dcomp.cpp
>>> +++ b/modules/gui/qt/maininterface/compositor_dcomp.cpp
>>> @@ -157,13 +157,18 @@ bool CompositorDirectComposition::init()
>>>           //| D3D11_CREATE_DEVICE_DEBUG
>>>               ;
>>> +    D3D_FEATURE_LEVEL requestedFeatureLevels[] = {
>>> +        D3D_FEATURE_LEVEL_11_1,
>>> +        D3D_FEATURE_LEVEL_11_0,
>>> +    };
>>> +
>>>       hr = D3D11CreateDevice(
>>>           nullptr,    // Adapter
>>>           D3D_DRIVER_TYPE_HARDWARE,
>>>           nullptr,    // Module
>>>           creationFlags,
>>> -        nullptr,
>>> -        0, // Highest available feature level
>>> +        requestedFeatureLevels,
>>> +        ARRAY_SIZE(requestedFeatureLevels),
>>>           D3D11_SDK_VERSION,
>>>           m_d3d11Device.GetAddressOf(),
>>>           nullptr,    // Actual feature level
>>> -- 2.25.1
>>> 
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel