[vlc-devel] [PATCH] Add Rust backed cue sheet parsing module

[Alexandre Janniaux]

Hi,

On Wed, Aug 19, 2020 at 11:42:29AM +0530, Kartik Ohri wrote:
> On Wed, Aug 19, 2020 at 10:45 AM Steve Lhomme <robux4 at ycbcr.xyz> wrote:
> > > diff --git a/modules/demux/playlist/playlist.c
> > b/modules/demux/playlist/playlist.c
> > > index d3cca7a502..d5142b7930 100644
> > > --- a/modules/demux/playlist/playlist.c
> > > +++ b/modules/demux/playlist/playlist.c
> > > @@ -130,6 +130,10 @@ vlc_module_begin ()
> > >           add_shortcut( "wpl" )
> > >           set_capability( "stream_filter", 310 )
> > >           set_callbacks( Import_WPL, Close_WPL )
> > > +    add_submodule ()
> > > +        set_description ( N_("Cue Sheet importer") )
> > > +        set_capability ( "stream_filter", 320 )
> > > +        set_callback ( Import_Cue_Sheet )
> >
> > I suppose this module requires some (large) Rust runtime to be linked
> > with it. I think it would be better in a separate module to avoid this
> > dependency on the regular module.
> >
> > I understand the rationale but I did not completely understand what should
> be done.
>

I guess Steve's point was that you should move the module
declaration in a new plugin instead of being a submodule to
the playlist plugin.

It means a separate compilation unit, probably different C
file here, and new libtool target in the automake configuration
with its own vlc_module_begin/end manifest.

Regards,
--
Alexandre Janniaux
Videolabs