[vlc-devel] [PATCH] audio output: Don't inherit "mute"

[Thomas Guillem]

On Thu, Aug 20, 2020, at 13:00, Steve Lhomme wrote:
> Is the variable in media_player.c still relevant then ?

No, but it is relevant on vlc_player.

> And var_InheritBool() in output.c should be changed to a vat_GetBool() ?

Yes, but it's not related to this patch. The "mute" variable already existed before this patch and a Inherit was used.

> 
> On 2020-08-20 11:39, Hugo Beauzée-Luyssen wrote:
> > Since it's not part of the config
> > ---
> >   src/audio_output/output.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/audio_output/output.c b/src/audio_output/output.c
> > index 260e27700e..485aa6fe3c 100644
> > --- a/src/audio_output/output.c
> > +++ b/src/audio_output/output.c
> > @@ -228,7 +228,7 @@ audio_output_t *aout_New (vlc_object_t *parent)
> >       /* Audio output module callbacks */
> >       var_Create (aout, "volume", VLC_VAR_FLOAT);
> >       var_AddCallback (aout, "volume", var_Copy, parent);
> > -    var_Create (aout, "mute", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
> > +    var_Create (aout, "mute", VLC_VAR_BOOL);
> >       var_AddCallback (aout, "mute", var_Copy, parent);
> >       var_Create (aout, "device", VLC_VAR_STRING);
> >       var_AddCallback (aout, "device", var_CopyDevice, parent);
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel