[vlc-devel] [PATCH] audio output: Don't inherit "mute"

[Rémi Denis-Courmont]

Looks ok but could have done a better job at explaining the rationale. IIRC this "mute" is just a read-only value representing the actual mute state of the audio output (as opposed to intended/requested state).

Le 20 août 2020 11:39:51 GMT+02:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>Since it's not part of the config
>---
> src/audio_output/output.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/audio_output/output.c b/src/audio_output/output.c
>index 260e27700e..485aa6fe3c 100644
>--- a/src/audio_output/output.c
>+++ b/src/audio_output/output.c
>@@ -228,7 +228,7 @@ audio_output_t *aout_New (vlc_object_t *parent)
>     /* Audio output module callbacks */
>     var_Create (aout, "volume", VLC_VAR_FLOAT);
>     var_AddCallback (aout, "volume", var_Copy, parent);
>-    var_Create (aout, "mute", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
>+    var_Create (aout, "mute", VLC_VAR_BOOL);
>     var_AddCallback (aout, "mute", var_Copy, parent);
>     var_Create (aout, "device", VLC_VAR_STRING);
>     var_AddCallback (aout, "device", var_CopyDevice, parent);
>-- 
>2.20.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200820/2cb7e08b/attachment.html>