[vlc-devel] [PATCH] [RFC]: rav1e/rust: handle rustup/cargo from contribs (to fixup)

[Alexandre Janniaux]

Hi,

On Mon, Aug 24, 2020 at 01:32:45PM +0200, Steve Lhomme wrote:
> On 2020-08-24 13:16, Rémi Denis-Courmont wrote:
> > Le maanantaina 24. elokuuta 2020, 11.12.45 EEST Thomas Guillem a écrit :
> > > On Sat, Aug 22, 2020, at 09:09, Rémi Denis-Courmont wrote:
> > > > Hi,
> > > >
> > > > Contribs/bin is fine for build tools. The name was just odd.
> > >
> > > Steve raised a good point. Can vlc modules easily have access to
> > > contribs/bin ?
> >
> > VLC modules cannot access build tools, wherever they may be.
> >
> > The question makes zero sense.
>
> protoc is in build tools.

The question seems to be more about modules/ buildsystem than
VLC modules and seems to have created confusion here.

Anyway, modules/ should probably stay agnostic of contrib/ and
only use contrib/whatever/bin within the path so as to override
what the system is providing, if needed. Meaning that it should
be possible to use system cargo / rustup by default without
contrib too.

The situation here is a bit annoying because cargo is a tool but
it's mainly used to install std sysroot and packages in specified
location. It might make sense to have cargo installed by extra
tools (thus optionnally installed) only if we can specify where
data must be installed for every commands of cargo / rustup.

Regards,
--
Alexandre Janniaux
Videolabs