[vlc-devel] [PATCH] [RFC]: rav1e/rust: handle rustup/cargo from contribs (to fixup)

[Rémi Denis-Courmont]

Le maanantaina 24. elokuuta 2020, 15.57.16 EEST Alexandre Janniaux a écrit :
> Hi,
> 
> On Mon, Aug 24, 2020 at 01:32:45PM +0200, Steve Lhomme wrote:
> > On 2020-08-24 13:16, Rémi Denis-Courmont wrote:
> > > Le maanantaina 24. elokuuta 2020, 11.12.45 EEST Thomas Guillem a écrit :
> > > > On Sat, Aug 22, 2020, at 09:09, Rémi Denis-Courmont wrote:
> > > > > Hi,
> > > > > 
> > > > > Contribs/bin is fine for build tools. The name was just odd.
> > > > 
> > > > Steve raised a good point. Can vlc modules easily have access to
> > > > contribs/bin ?
> > > 
> > > VLC modules cannot access build tools, wherever they may be.
> > > 
> > > The question makes zero sense.
> > 
> > protoc is in build tools.

That's like the worst possible example.

Given is needed in contrib anyway, it's ridiculous that it's duplicated in the 
crappy extras/tools.

> The question seems to be more about modules/ buildsystem than
> VLC modules and seems to have created confusion here.

There are no problems with modules as such, and there are no particular 
problems with the VLC build system.
 
> Anyway, modules/ should probably stay agnostic of contrib/ and
> only use contrib/whatever/bin

Absolutely not.

contrib/TRIPLET/bin/ is where host binaries get installed. You should leave 
that alone, as it can't work in cross-compilation.

Build programs from contrib go to contrib/bin/. They get a triplet prefix if 
they are platform-specific: that is consistent with autoconf tools and programs 
detection macros, and how system-provided build tools are laid out in /usr/
bin, /usr/local/bin or wherever.

The only minor problem with building tools in contribs is that, if the tool is 
platform-independent and if there are more than one contrib platform in the 
tree, then the tool will be needlessly rebuilt and reinstalled by each 
platform builds.

-- 
レミ・デニ-クールモン
http://www.remlab.net/