[vlc-devel] [PATCH v5 00/24] Get rid of the control command API

Steve Lhomme robux4 at ycbcr.xyz
Mon Aug 24 16:52:54 CEST 2020

On 2020-08-24 16:01, Rémi Denis-Courmont wrote:
> Le maanantaina 24. elokuuta 2020, 10.41.41 EEST Steve Lhomme a écrit :
>> Changes since v4:
>> - split the "mouse-moved" variables in 2 versions: one in video area
>> coordinates one in original video coordinates.
> We never did that because it is utterly pointless.
> By definition, the window coordinates can only mean anything in the window
> provider. And the window provider already knows those values, needs not have
> core callbacks to receive its own events.

There's no "can only mean". hotkeys and gestures already interpret the 
mouse movements. And as I already explained the fact that the video is 
magnified 100x shouldn't mean you have to move your mouse 100x faster to 
activate the gesture. It's "window" coordinates, not "video" coordinates.

It is like that now but it's a bug. Probably no-one ever noticed because 
only magnify, deinterlace and transform change the mouse coordinates.

> As the obvious example, if you want to draw something where the pointer is,
> you will either need:
> - the window handle and the coordinates relative to the window (if compositing
> is involved, this won't even match the video area coordinates), or
> - absolute coordinates (relative to root window).

This is not how the "mouse-xxx" are handled. Only gesture and hotkeys 
use these values and they should not be translated.

To keep old external still working I might use a different for those and 
keep "mouse-moved" in video coordinates.

> -1
* -1

More information about the vlc-devel mailing list