[vlc-devel] [PATCH v5 00/24] Get rid of the control command API

[Rémi Denis-Courmont]

Le maanantaina 24. elokuuta 2020, 17.52.54 EEST Steve Lhomme a écrit :
> On 2020-08-24 16:01, Rémi Denis-Courmont wrote:
> > Le maanantaina 24. elokuuta 2020, 10.41.41 EEST Steve Lhomme a écrit :
> >> Changes since v4:
> >> - split the "mouse-moved" variables in 2 versions: one in video area
> >> coordinates one in original video coordinates.
> > 
> > We never did that because it is utterly pointless.
> > 
> > By definition, the window coordinates can only mean anything in the window
> > provider. And the window provider already knows those values, needs not
> > have core callbacks to receive its own events.
> 
> There's no "can only mean". hotkeys and gestures already interpret the
> mouse movements. And as I already explained the fact that the video is
> magnified 100x shouldn't mean you have to move your mouse 100x faster

Why not? If your monitor resolution is 100x times that of the original video, 
it makes perfect sense that the speed is 100x if you measure video pixel 
speed. Indeed, until recently, hotkeys did not even care about mouse 
coordinates - only clicks. And the current rare usage (VR) has always been 
done with video coordinates.

Not that there are no use cases where you want the window coordinates, for 
some definition of window. In fact in some of those cases, that definition of 
window will match that of the vout_window_t. But if you don't know which 
window generated the event, that's still pretty useless.

> to activate the gesture. It's "window" coordinates, not "video" coordinates.
> 
> It is like that now but it's a bug. Probably no-one ever noticed because
> only magnify, deinterlace and transform change the mouse coordinates.

What? Of course not! Coordinate translation takes place as soon as the video 
is zoomed in or out. That's *very* common. Deinterlace is quite common too.

The odd & broken one here is the (desktop) gestures interface, which is 
rarely, if ever, used. And it should vary based on the DPI, so providing the 
window coordinates is not going to fix it anyway. It's highly questionable that 
it should even catch the VLC video window events.

-1

-- 
レミ・デニ-クールモン
http://www.remlab.net/