[vlc-devel] [PATCH 0/3] Fix --crop/--zoom/--aspect-ratio command line usage

[Alexandre Janniaux]

Hi,

On Mon, Aug 31, 2020 at 12:45:36PM +0300, Rémi Denis-Courmont wrote:
> Hi,
>
> I did ask if/when to apply the CLI vout settings, and explicitly noted that users had contradictory (and sometimes impossible or unrealistic) expectations in those respects.
>
> The only opinion (not mine) was to apply them only at start. Thus I removed the trigger-callback hacks I'd previously made that did the opposite.
>
> As far why it works for zoom and not the other two ratii, I don't know. I can only presume that I overlooked or accidentally rebased away the missing initialisation code.

Thanks for the detailed explanation! :)

I'd like to add, for people who might be working on this,
that the behaviour on mobile platforms (maybe even libVLC
in general) is different than what happens on Windows for
example. For instance, zoom state changes cannot produce
a bigger image/vout window, because the vout window size
is fixed.

Thus, it's probably important to test that the potential
candidates for a fix are not breaking the playback on those
platform by creating bigger surface than they should draw,
which in the current tree was a behaviour that Thomas fixed.

Regards,
--
Alexandre Janniaux
Videolabs

> Le 31 août 2020 12:22:39 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
> >On 2020-08-31 11:02, Rémi Denis-Courmont wrote:
> >> Before the patches were merged, here, ask the secretary and I don't
> >like
> >> your tone.
> >
> >There is no tone. It's just a basic question. Neither Thomas nor I
> >remember this vote and even less a result.
> >
> >Looking at the 3 patches, they have no even been proposed for review.
> >The patches around these are all about cleaning the internals of
> >picture
> >Aspect-ratio/Crop/Zoom/etc and are mostly OK. But removing the external
> >
> >parameters seem to be a stretch.
> >
> >> Le 31 août 2020 07:58:54 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a
> >
> >> écrit :
> >>
> >>     On 2020-08-27 16:51, Rémi Denis-Courmont wrote:
> >>
> >>         Le torstaina 27. elokuuta 2020, 13.06.32 EEST Steve Lhomme a
> >écrit :
> >>
> >>             Not sure why these were commited.
> >>
> >>         We had a vote and decided to do that.
> >>
> >>
> >>     When and where was that voted and where do I see the results of
> >that vote ?
> >>
> >------------------------------------------------------------------------
> >>     vlc-devel mailing list
> >>     To unsubscribe or modify your subscription options:
> >>     https://mailman.videolan.org/listinfo/vlc-devel
> >>
> >>
> >> --
> >> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
> >excuser
> >> ma brièveté.
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
>
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel