[vlc-devel] [PATCH 0/3] Fix --crop/--zoom/--aspect-ratio command line usage
thomas at gllm.fr
Mon Aug 31 13:21:40 CEST 2020
On Mon, Aug 31, 2020, at 11:45, Rémi Denis-Courmont wrote:
> I did ask if/when to apply the CLI vout settings, and explicitly noted that users had contradictory (and sometimes impossible or unrealistic) expectations in those respects.
> The only opinion (not mine) was to apply them only at start. Thus I removed the trigger-callback hacks I'd previously made that did the opposite.
I remember agreeing for this patch set. Maybe it was during a workshop and orally.
I guess it always good to write on the commit log by whom it was approved/voted. This will only help us to understand the context.
Anyway, I think we all improved our review process and commit logs/messages since then.
> As far why it works for zoom and not the other two ratii, I don't know. I can only presume that I overlooked or accidentally rebased away the missing initialisation code.
> Le 31 août 2020 12:22:39 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>> On 2020-08-31 11:02, Rémi Denis-Courmont wrote:
>>> Before the patches were merged, here, ask the secretary and I don't like
>>> your tone.
>> There is no tone. It's just a basic question. Neither Thomas nor I
>> remember this vote and even less a result.
>> Looking at the 3 patches, they have no even been proposed for review.
>> The patches around these are all about cleaning the internals of picture
>> Aspect-ratio/Crop/Zoom/etc and are mostly OK. But removing the external
>> parameters seem to be a stretch.
>>> Le 31 août 2020 07:58:54 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a
>>> écrit :
>>> On 2020-08-27 16:51, Rémi Denis-Courmont wrote:
>>> Le torstaina 27. elokuuta 2020, 13.06.32 EEST Steve Lhomme a écrit :
>>> Not sure why these were commited.
>>> We had a vote and decided to do that.
>>> When and where was that voted and where do I see the results of that vote ? vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser
>>> ma brièveté.
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel