[vlc-devel] [PATCH] macosx/sparkle: set feed URL based on architecture

[Felix Paul Kühne]

Hi Steve,

> Am 01.12.2020 um 12:02 schrieb Steve Lhomme <robux4 at ycbcr.xyz>:
> 
> On 2020-11-30 19:16, Felix Paul Kühne wrote:
>> From: Felix Paul Kühne <felix at feepk.net>
>> ---
>>  modules/gui/macosx/VLCMain.m | 10 +++++++++-
>>  share/Info.plist.in          |  2 --
>>  2 files changed, 9 insertions(+), 3 deletions(-)
>> diff --git a/modules/gui/macosx/VLCMain.m b/modules/gui/macosx/VLCMain.m
>> index 6668ea456d..4bf6b02382 100644
>> --- a/modules/gui/macosx/VLCMain.m
>> +++ b/modules/gui/macosx/VLCMain.m
>> @@ -288,7 +288,15 @@ - (void)applicationWillFinishLaunching:(NSNotification *)aNotification
>>      _coreinteraction = [VLCCoreInteraction sharedInstance];
>>    #ifdef HAVE_SPARKLE
>> -    [[SUUpdater sharedUpdater] setDelegate:self];
>> +    SUUpdater *updater = [SUUpdater sharedUpdater];
>> +    NSURL *feedURL;
>> +#ifdef __x86_64__
>> +    feedURL = [NSURL URLWithString:@"https://update.videolan.org/vlc/sparkle/vlc-intel64.xml"];
>> +#else
>> +    feedURL = [NSURL URLWithString:@"https://update.videolan.org/vlc/sparkle/vlc-arm64.xml"];
> 
> Right now this URL gives a 404 error. Will it lead to some error displayed to the user ? Will the URL become automatically updated when a new release is done ?

It will only lead to a displayed error if the user explicitly asks the installed VLC to be updated. However, the URL will of course be populated ahead of the release.

Best regards,

Felix