[vlc-devel] [PATCH] macosx/sparkle: set feed URL based on architecture

[Steve Lhomme]

On 2020-11-30 19:16, Felix Paul Kühne wrote:
> From: Felix Paul Kühne <felix at feepk.net>
> 
> ---
>   modules/gui/macosx/VLCMain.m | 10 +++++++++-
>   share/Info.plist.in          |  2 --
>   2 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/modules/gui/macosx/VLCMain.m b/modules/gui/macosx/VLCMain.m
> index 6668ea456d..4bf6b02382 100644
> --- a/modules/gui/macosx/VLCMain.m
> +++ b/modules/gui/macosx/VLCMain.m
> @@ -288,7 +288,15 @@ - (void)applicationWillFinishLaunching:(NSNotification *)aNotification
>       _coreinteraction = [VLCCoreInteraction sharedInstance];
>   
>   #ifdef HAVE_SPARKLE
> -    [[SUUpdater sharedUpdater] setDelegate:self];
> +    SUUpdater *updater = [SUUpdater sharedUpdater];
> +    NSURL *feedURL;
> +#ifdef __x86_64__
> +    feedURL = [NSURL URLWithString:@"https://update.videolan.org/vlc/sparkle/vlc-intel64.xml"];
> +#else
> +    feedURL = [NSURL URLWithString:@"https://update.videolan.org/vlc/sparkle/vlc-arm64.xml"];

Right now this URL gives a 404 error. Will it lead to some error 
displayed to the user ? Will the URL become automatically updated when a 
new release is done ?

> +#endif
> +    [updater setFeedURL:feedURL];
> +    [updater setDelegate:self];
>   #endif
>   }
>   
> diff --git a/share/Info.plist.in b/share/Info.plist.in
> index 0fe1a4682d..711721fdee 100644
> --- a/share/Info.plist.in
> +++ b/share/Info.plist.in
> @@ -1520,8 +1520,6 @@
>   	<string>VLCApplication</string>
>   	<key>NSSupportsAutomaticGraphicsSwitching</key>
>   	<true/>
> -	<key>SUFeedURL</key>
> -	<string>https://update.videolan.org/vlc/sparkle/vlc-intel64.xml</string>
>   	<key>SUPublicDSAKeyFile</key>
>   	<string>dsa_pub.pem</string>
>   	<key>UTExportedTypeDeclarations</key>
> -- 
> 2.24.3 (Apple Git-128)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>