[vlc-devel] [PATCH] csa: do not handle impossible NULL argument

Steve Lhomme robux4 at ycbcr.xyz
Thu Dec 3 18:36:58 CET 2020


On 2020-12-03 17:29, Rémi Denis-Courmont wrote:
> Le torstaina 3. joulukuuta 2020, 11.14.49 EET Steve Lhomme a écrit :
>> p_sys->csa in ts.c can be NULL (see csaSetup()) and the ts code will
>> work fine. So the NULL case is very much used (and I believe the common
>> case).
> 
> I don't know what code base you are referring to. csa_UseKey() has a single
> call site in vlc.git and that's the one getting patched here.

p_sys->csa in ts.c can still be NULL. You didn't change that in any of 
your patches. So your assumption "impossible NULL argument" is wrong.

> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list