[vlc-devel] [PATCH] csa: do not handle impossible NULL argument

Rémi Denis-Courmont remi at remlab.net
Thu Dec 3 18:54:25 CET 2020

Le torstaina 3. joulukuuta 2020, 19.36.58 EET Steve Lhomme a écrit :
> On 2020-12-03 17:29, Rémi Denis-Courmont wrote:
> > Le torstaina 3. joulukuuta 2020, 11.14.49 EET Steve Lhomme a écrit :
> >> p_sys->csa in ts.c can be NULL (see csaSetup()) and the ts code will
> >> work fine. So the NULL case is very much used (and I believe the common
> >> case).
> > 
> > I don't know what code base you are referring to. csa_UseKey() has a
> > single
> > call site in vlc.git and that's the one getting patched here.
> p_sys->csa in ts.c can still be NULL.

So what?

> You didn't change that in any of your patches.

Actually, it does change in the other series, but that's not even relevant.

> So your assumption "impossible NULL argument" is wrong.

And in what code path is it wrong, exactly?


More information about the vlc-devel mailing list