[vlc-devel] [PATCH 09/12] network: io: Remove VLA usages

Hugo Beauzée-Luyssen hugo at beauzee.fr
Wed Dec 9 10:25:50 CET 2020

On Wed, Dec 9, 2020, at 10:20 AM, Rémi Denis-Courmont wrote:
> No it is not fine as already explained and as is obvious from reading 
> most call sites.
> -1

AFAICS all callsites except lua handle the error explicitly. Lua forwards the fd to its own caller which is responsible for checking the return value as can be expected.
I don't understand why an additional error case is so problematic.
Also, as for the other patches, this can't be expected to compile everywhere, since VLA are not mandatory.

  Hugo Beauzée-Luyssen
  hugo at beauzee.fr

More information about the vlc-devel mailing list