[vlc-devel] [PATCH 09/12] network: io: Remove VLA usages

Rémi Denis-Courmont remi at remlab.net
Wed Dec 9 10:31:40 CET 2020

VLA are required just like hosting and threads and atomics are required. By VLC, and in the case of VLAs also by C99.

None of those are required by C11 and that's completely irrelevant, as VLC is not meant to run on bare metal or historical ISAs.

Le 9 décembre 2020 11:25:50 GMT+02:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>On Wed, Dec 9, 2020, at 10:20 AM, Rémi Denis-Courmont wrote:
>> No it is not fine as already explained and as is obvious from reading
>> most call sites.
>> -1
>AFAICS all callsites except lua handle the error explicitly. Lua
>forwards the fd to its own caller which is responsible for checking the
>return value as can be expected.
>I don't understand why an additional error case is so problematic.
>Also, as for the other patches, this can't be expected to compile
>everywhere, since VLA are not mandatory.
>  Hugo Beauzée-Luyssen
>  hugo at beauzee.fr
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:

Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201209/b4315d0d/attachment.html>

More information about the vlc-devel mailing list