[vlc-devel] [PATCH 09/12] network: io: Remove VLA usages

[Thomas Guillem]

Rémi, your point of view is valid, following the C11 specs is essential in my opinion.
But from my point of view, we should also focus and supporting more tool chains/OS if the cost is reasonable.

Supporting MSVC officially has a small cost in my opinion, it doesn't require a full rewrite of a large part of our code. So, even if VLA were mandatory in the C11 specs, my opinion would be the same: removing it to add support for a new toolchain that could bring us more developers.

On Fri, Dec 11, 2020, at 12:01, Hugo Beauzée-Luyssen wrote:
> On Fri, Dec 11, 2020, at 11:28 AM, Rémi Denis-Courmont wrote:
> > > * VLA we don't really need.
> > 
> > We do as already explained.
> > 
> 
> I'm sure there's a way to reduce the usages in more locations without a 
> performance cost, but I really don't see VLA as a hard requirement, 
> like _Generic or atomics.
> I'll see if I find a more suitable approach for some of the usages in 
> the core.
> 
> > There was a decision to *upgrade* to C++11 then C11. There never was a 
> > decision to downgrade from C99 by cropping what C11 made optional. There's 
> > been a lot of pretexts about how this is a conformance problem in VLC code, 
> > but really this is all MSVC problems. It's a case of two people wanting to 
> > force everybody else to use to change the coding standards agreed by the 
> > community for their own personal wishes.
> > 
> 
> No, I am not forcing anything. If I had forced anything we'd probably 
> be having a discussion about reverting, if not worse. 
> I'm trying to improve VLC's support of MSVC but I'm not forcing 
> anything.
> And arguing that it's only 2 people wanting to support MSVC is a 
> strange argument because off course nobody uses MSVC, it doesn't 
> compile when using it. You can't lock people out and then claim that 
> they are not here.
> 
> > Well no. This project does not work your way or the highway.
> 
> Given that you suggested that we fork VLC if we disagreed about MSVC 
> support, it kind of seems that it sometimes is, but I'd rather find a 
> compromise.
> 
> -- 
>   Hugo Beauzée-Luyssen
>   hugo at beauzee.fr
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel