[vlc-devel] [PATCH 1/3] decoder: fix forgotten vout error state

Rémi Denis-Courmont remi at remlab.net
Thu Dec 17 11:21:16 UTC 2020

Le torstaina 17. joulukuuta 2020, 11.52.03 EET Thomas Guillem a écrit :
> If the pool allocation fails or if the vout fails to start (via
> input_resource_RequestVout()), an error is returned from
> decoder_UpdateVideoFormat().

That's incorrect. A pool shall not be allocated if the decoder manages 
pictures itself. It's a big waste of memory. The pool needs to be allocated if 
and *only* if the decoder invokes the video.buffer_new() calback.

I do get it that that's a preexisting problem not introduced by this patch, 
but it still does make this patch completley moot.

Реми Дёни-Курмон

More information about the vlc-devel mailing list